Skip to content

feat(node): Ensure connect spans have better data #12130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2024
Merged

feat(node): Ensure connect spans have better data #12130

merged 2 commits into from
May 21, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented May 21, 2024

Ensuring connect spans have correct op & origin.

Also streamlining E2E test app for this.

@mydea mydea requested review from lforst, Lms24 and andreiborza May 21, 2024 07:53
@mydea mydea self-assigned this May 21, 2024
andreiborza
andreiborza approved these changes May 21, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser 21.72 KB (0%)
@sentry/browser (incl. Tracing) 32.88 KB (0%)
@sentry/browser (incl. Tracing, Replay) 68.23 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.61 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.27 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.27 KB (0%)
@sentry/browser (incl. Feedback) 37.68 KB (0%)
@sentry/browser (incl. sendFeedback) 26.29 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.66 KB (0%)
@sentry/react 24.41 KB (0%)
@sentry/react (incl. Tracing) 35.87 KB (0%)
@sentry/vue 25.66 KB (0%)
@sentry/vue (incl. Tracing) 34.69 KB (0%)
@sentry/svelte 21.86 KB (0%)
CDN Bundle 24.26 KB (0%)
CDN Bundle (incl. Tracing) 34.31 KB (0%)
CDN Bundle (incl. Tracing, Replay) 68 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 72.97 KB (0%)
CDN Bundle - uncompressed 71.33 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 101.74 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 211.36 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 223.66 KB (0%)
@sentry/nextjs (client) 35.09 KB (0%)
@sentry/sveltekit (client) 33.46 KB (0%)
@sentry/node 141.54 KB (+0.01% 🔺)
@sentry/aws-serverless 128.08 KB (0%)

@mydea mydea mentioned this pull request May 21, 2024
Open
@mydea mydea force-pushed the fn/connect-spans branch from 28f05bc to 6d50d5d Compare May 21, 2024 10:34
@mydea mydea merged commit 77ff5d9 into develop May 21, 2024
85 checks passed
@mydea mydea deleted the fn/connect-spans branch May 21, 2024 11:27
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Closed
@omznc omznc mentioned this pull request Jun 12, 2024
Open
@naiba4 naiba4 mentioned this pull request Jun 13, 2024
Open
@koushikpuppala koushikpuppala mentioned this pull request Jun 13, 2024
Closed
@naiba4 naiba4 mentioned this pull request Jun 13, 2024
Open
@koushikpuppala koushikpuppala mentioned this pull request Jun 13, 2024
Closed
@omznc omznc mentioned this pull request Jun 14, 2024
Open
@FengShangWuQi FengShangWuQi mentioned this pull request Jun 16, 2024
Closed
@koushikpuppala koushikpuppala mentioned this pull request Jun 17, 2024
Closed
@naiba4 naiba4 mentioned this pull request Jun 18, 2024
Open
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreiborza andreiborza andreiborza approved these changes

@lforst lforst Awaiting requested review from lforst

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @andreiborza